test(build): Sync fonts to Toolkit #5832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: A new font was added for Amazon Q by adding the SVG to `packages/core/resources/icons`. Then the `generateIcons.ts` script will read this and add the icon to our custom font that we generate. Another part of this script also updates the package.json with this new icon. The problem is that the package.json change was only reflected in the Amazon Q package.json and not the Toolkit package.json. This needs to be reflected in the Toolkit package.json as well since we only generate a single font for both extensions, instead of a customized font for each. So every time I did a development build the package.json would change. Solution: Run the generate icon script for Toolkit and commit the package.json changes. Signed-off-by: nkomonen-amazon <[email protected]>
|
This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions. |
nkomonen-amazon
changed the title
nkomonen-amazon
changed the title
hayemaxi
approved these changes
Oct 22, 2024
nkomonen-amazon
changed the title
justinmk3
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Every time I did a development build the package.json would change.
Background: New fonts are added for Amazon Q by adding the SVG to
packages/core/resources/icons. Then thegenerateIcons.tsscript will read this and add the icon to our custom font that we generate. Another part of this script also updates the package.json with this new icon.The problem is that the package.json change was only reflected in the Amazon Q package.json and not the Toolkit package.json. This needs to be reflected in the Toolkit package.json as well since we only generate a single font for both extensions, instead of a customized font for each.
Solution:
Run the generate icon script for Toolkit and commit the package.json changes.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.